[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Simone Orsi - Agile BG - Domsense
Simone Orsi - Agile BG - Domsense has proposed merging lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653

Add 'progress' attribure to project.task view.
See also:
https://code.launchpad.net/~openerp-community/openobject-server/trunk-gantt-view-add-progress
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

=== modified file 'project/project_view.xml'
--- project/project_view.xml 2012-01-05 13:50:32 +0000
+++ project/project_view.xml 2012-01-23 10:39:53 +0000
@@ -463,7 +463,7 @@
             <field name="type">gantt</field>
             <field eval="2" name="priority"/>
             <field name="arch" type="xml">
-                <gantt color="user_id" date_start="date_start" date_stop="date_end" string="Tasks" default_group_by="project_id,user_id">
+                <gantt color="user_id" date_start="date_start" date_stop="date_end" progress="progress" string="Tasks" default_group_by="project_id,user_id">
                 </gantt>
             </field>
         </record>


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Raphael Collet (OpenERP)
Review: Disapprove

We have discussed internally the issue of supporting progress in Gantt views.  It was decided that version 6.1 will not support it, because of some visual issues (defining progress on tasks gives a progress on project level that does not match the progress of projects).  Moreover, Gantt views in the web client have just been reimplemented a few days ago.

Hence I reject this merge proposal, for the sake of not leaving it pending.

Thanks anyway for your contribution!

Raphael

--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Raphael Collet (OpenERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
The proposal to merge lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons has been updated.

    Status: Needs review => Rejected

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Davide Corio - agilebg.com
In reply to this post by Simone Orsi - Agile BG - Domsense
actually:

https://bugs.launchpad.net/openerp-web/+bug/908764
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Davide Corio - agilebg.com
In reply to this post by Simone Orsi - Agile BG - Domsense
sorry, pressed some button too eary...

there's one thing i don't understand.

at least 2 people provided the same patch to the same issue and you said that those are useless because you're rewriting that feature.
Since we never had the chance to correctly use the project addon (because of bugs and bad design issues) and we started to fix it by ourselves, we'd like now to understand if you're about to release a working project addon in time for 6.1 or if we have to keep developing our own one and release it so people can use openerp for project management.

i think that, in this case, the correct behaviour is to point out the community to the branch where you are implementing the new code so we can help you or stop what we're doing without wasting our time.

So...it's ok you decided to reimplement this, but we need to know this kind of infos :-/ So please...post something somewhere! :-(
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress into lp:openobject-addons

Antony Lesuisse (OpenERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
Percent progress was not part of the functionnal specification for the 6.1 gantt view. This week, we (actually niv) did a total rewrite of the gantt view because the rc1 code was not clean and too buggy. The rewrite is shorter (230 lines vs 550 lines) cleaner and bug free. And this is a good thing.

We are not against percent progress but you will need rewrite your merge prop against the new implementation in trunk, because this merge prop isn't relevant anymore:

https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649

However you will certainly understand that there are no guarantee that it will be merged into 6.1 as we dont want to delay the release for an unplanned new feature.

those two seems ok once the progress support is cleanly implementent in web_gantt:

https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
https://code.launchpad.net/~openerp-community/openobject-server/trunk-gantt-view-add-progress/+merge/89648

The same kind of rewrite is also planned this week for web_diagram.
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp