[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Divyesh Makwana(OpenERP)
Divyesh Makwana(OpenERP) has proposed merging lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #917732 in OpenERP Addons: "Compute asset wizard don't include asset depreciation line date same like period start/end date"
  https://bugs.launchpad.net/openobject-addons/+bug/917732

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057

Hello Sir,

I have fix the issue: https://bugs.launchpad.net/openobject-addons/+bug/917732 "Compute asset wizard don't include asset depreciation line date same like period start/end date".

Thanks and Regards,

Divyesh Makwana(MDI)
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

=== modified file 'account_asset/account_asset.py'
--- account_asset/account_asset.py 2011-12-21 22:06:36 +0000
+++ account_asset/account_asset.py 2012-01-25 08:56:27 +0000
@@ -309,7 +309,7 @@
         period_obj = self.pool.get('account.period')
         depreciation_obj = self.pool.get('account.asset.depreciation.line')
         period = period_obj.browse(cr, uid, period_id, context=context)
-        depreciation_ids = depreciation_obj.search(cr, uid, [('asset_id', 'in', ids), ('depreciation_date', '<', period.date_stop), ('depreciation_date', '>', period.date_start), ('move_check', '=', False)], context=context)
+        depreciation_ids = depreciation_obj.search(cr, uid, [('asset_id', 'in', ids), ('depreciation_date', '<=', period.date_stop), ('depreciation_date', '>=', period.date_start), ('move_check', '=', False)], context=context)
         return depreciation_obj.create_move(cr, uid, depreciation_ids, context=context)
 
     def create(self, cr, uid, vals, context=None):


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Purnendu Singh (OpenERP)
Review: Approve


--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Raphael Collet (OpenERP)
In reply to this post by Divyesh Makwana(OpenERP)
Review: Approve

On its way to be merged.
Thanks,
Raphael
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

noreply
In reply to this post by Divyesh Makwana(OpenERP)
The proposal to merge lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons has been updated.

    Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Raphael Collet (OpenERP)
In reply to this post by Divyesh Makwana(OpenERP)
The proposal to merge lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons has been updated.

    Status: Merged => Work in progress

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Raphael Collet (OpenERP)
In reply to this post by Divyesh Makwana(OpenERP)
Review: Needs Fixing

It breaks the tests in account_asset.  Please install the module with tests enabled, you will see that something is broken...

--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt into lp:openobject-addons

Purnendu Singh (OpenERP)
In reply to this post by Divyesh Makwana(OpenERP)
Review: Resubmit

Hello Raphael Collet,

Update the demo data so it will not break the YML test at the time of installation.

Thanks,
Purnendu Singh
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-917732-pslt/+merge/90057
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/trunk-bug-917732-pslt.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp