[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons

Niels Huylebroeck
Niels Huylebroeck has proposed merging lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #931330 in OpenERP Server: "[trunk] account_bank_statement_extensions creates duplicate bank_ids field"
  https://bugs.launchpad.net/openobject-server/+bug/931330

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids.

=== modified file 'account_bank_statement_extensions/__openerp__.py'

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons

Olivier Dony (OpenERP)
Review: Disapprove

Hi,

The diff appear empty, probably because the trunk code has been fixed a while ago (your branch seems based on rev 3635, this was fixed at rev 3639)
See also my comment on the bug report.

Thanks,
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons

Olivier Dony (OpenERP)
In reply to this post by Niels Huylebroeck
The proposal to merge lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons has been updated.

    Status: Needs review => Rejected

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids into lp:openobject-addons

Olivier Dony (OpenERP)
In reply to this post by Niels Huylebroeck
Sorry, of course I meant:
 .. seems based on rev 6365, this was fixed at rev 6439)
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix_duplicate_bank_ids/+merge/92737
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix_duplicate_bank_ids.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp