[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

Niels Huylebroeck
Niels Huylebroeck has proposed merging lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #1127198 in OpenERP Addons: "[6.1/Trunk/7.0] wrong date in import invoices in bank statements"
  https://bugs.launchpad.net/openobject-addons/+bug/1127198

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

=== modified file 'account_voucher/wizard/account_statement_from_invoice.py'
--- account_voucher/wizard/account_statement_from_invoice.py 2012-12-18 17:55:47 +0000
+++ account_voucher/wizard/account_statement_from_invoice.py 2013-05-08 16:30:48 +0000
@@ -94,7 +94,7 @@
                             'account_id': result['value'].get('account_id', statement.journal_id.default_credit_account_id.id),
                             'company_id': statement.company_id.id,
                             'currency_id': statement.currency.id,
-                            'date': line.date,
+                            'date': statement.date,
                             'amount': sign*amount,
                             'payment_rate': result['value']['payment_rate'],
                             'payment_rate_currency_id': result['value']['payment_rate_currency_id'],
@@ -119,7 +119,7 @@
                 'statement_id': statement_id,
                 'ref': line.ref,
                 'voucher_id': voucher_id,
-                'date': time.strftime('%Y-%m-%d'),
+                'date': statement.date,
             }, context=context)
         return {'type': 'ir.actions.act_window_close'}
 


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

Serpent Consulting Services
Review: Approve

Faced a similar issue and your fix is perfect!
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

Open Net Sàrl
In reply to this post by Niels Huylebroeck
Hi,
Could you please review and merge it, It's been such a long time...
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

Martin Trigaux (OpenERP)
In reply to this post by Niels Huylebroeck
Review: Approve

Hello,

Sorry for the long delay on this one and thanks for your work to fix the bug.

One small remark: Please do not make write calls in on_change methods. on_change should only be for user interface, no impact on the data (eg: if I close my browser after making the change in edit mode without saving).

On the bug report, you mentioned the issue that the date will be changed when confirming is late. On the other hand it is not really problematic as long as these are in draft.
What do you think ?

In the meanwhile I have merged your changes (everything except the on_change) into 7.0

Regards

revno: 9799 [merge]
revision-id: [hidden email]-20140129172009-vbp5n1nco51kaly8

--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

noreply
In reply to this post by Niels Huylebroeck
The proposal to merge lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0 has been updated.

    Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] something new and cool

Christian Fast
In reply to this post by Niels Huylebroeck
Greetings,

Have you already  seen that new stuff? You've  got  to take a  look, it is awesome,  check it out http://sale.lkn4snow.com/babb

Good wishes, Openerp-community


--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] useful article

Christian Fast
In reply to this post by Niels Huylebroeck
Dear,

I've read an  article recently,  it seems to be really full of amazing facts, it may interest  you too.  You  may  red it here  http://now.lkn4snow.com/cacb

Faithfully, Openerp-community


--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

new methods

Christian Fast
In reply to this post by Niels Huylebroeck
Hi friend!

I've just found some new methods to solve  the  problem you're facing, read more here http://lottopools.me/explode.php?6f6e

Wishes, Openerp-community


--
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date/+merge/163006
Your team OpenERP Community (OBSOLETE) is subscribed to branch lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date.
Loading...