[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher into lp:~openerp-dev/openobject-addons/7.0-587621-opw-skh

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher into lp:~openerp-dev/openobject-addons/7.0-587621-opw-skh

Niels Huylebroeck
Niels Huylebroeck has proposed merging lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher into lp:~openerp-dev/openobject-addons/7.0-587621-opw-skh.

Requested reviews:
  Somesh Khare(OpenERP) (skh-openerp)

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932

Instead of simply unhooking any draft vouchers from the bank.statement.line we clean them up when you change the amount of the bank.statement.line.
--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

=== modified file 'account_voucher/account_voucher.py'
--- account_voucher/account_voucher.py 2013-03-21 13:38:48 +0000
+++ account_voucher/account_voucher.py 2013-03-22 12:20:26 +0000
@@ -1561,6 +1561,14 @@
         return res
 
     def onchange_amount(self, cr, uid, ids, amount, context=None):
+        # If the line already has a voucher_id and the state of it is 'draft'
+        # it means this bank statement was cancelled before and we should delete
+        # the voucher AND clear the field voucher_id.
+        if ids:
+            for line in self.browse(cr, uid, ids, context=context):
+                if line.voucher_id and line.voucher_id.state == 'draft':
+                    # Instead of orphaning this draft voucher, we will delete it
+                    line.voucher_id.unlink()
         return {'value' :  {'voucher_id' : False}}
 
     def _amount_reconciled(self, cursor, user, ids, name, args, context=None):


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher into lp:~openerp-dev/openobject-addons/7.0-587621-opw-skh

Naresh(OpenERP)
Review: Needs Information

Hello Niels,

Well, this does not seem to be an issue that needs an OPW cover to get in to stable, rather it seems an improvement. Secondly, according to the current stable source the related vouchers are set to cancelled state when you cancel the bank statement and later if you confirm the bank statement again the same voucher will be in posted state. Which is so far good.

Now comes your case(@Niels) for which you have proposed a merge proposal https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932 where in you unlink the isolated vouchers that are result of changing the original amount on the bank statement line. But here if you look closely as soon as you change the original amount on the bank statement line the button on the line will turn *red* if the balance does not match that means you need to take care you are reconciling it with the correct amount. To Fix this you need to click on the button to and change the *Allocation* value to the actual value you want to reconcile. As soon as you correct that you see the button turns *Green* means everything is correctly setup and now you can proceed with reconciliation. In this case the previous voucher will be in cancelled state and a new entry will be created and reconciled(posted).

Keeping the history of vouchers (altered ones) seems good. instead of setting them to draft and later unlinking them.

However, we its still open to be discussed.

Thanks,
--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] shock and amazement

debaetsr
In reply to this post by Niels Huylebroeck
Hey friend,

I was amazed by that shocking article I've  recenly  read, please read it and tell me your  opinion <http://helpful.getoffmylawngame.com/e4eocue>

See you soon, ruben



--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] try this cool stuff

Christian Fast
In reply to this post by Niels Huylebroeck
Hello,

I've picked  some cool stuff for you, you're going to love this!  Check it  out http://damiano.jodibassimarkoff.com/3839


Bests, Lukas Friedl


--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] day full of surprises

Christian Fast
In reply to this post by Niels Huylebroeck
Greetings,

I'm so excited to tell  you  about yesterday that was full of pleasant  surprises, just take a look at that http://plan.feigenbaum.me/0504


Openerp-community


--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] wow, just look at that!

Christian Fast
In reply to this post by Niels Huylebroeck
Hello friend,

Look at  what  I've just found!  It is something really  amazing, you need to see  that! Check it  out  http://noble.erictoddfeigenbaum.com/9998

Kind regards, Openerp-community


--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

☢I'm so excited about the latest news

Christian Fast
In reply to this post by Niels Huylebroeck
Hey!

Have  you heard the latest news? I'm  so  excited  about it, please read it here  http://www.amazonsistemas.com.br/communication.php?4f4e


Faithfully, Openerp-community



From: mp154932 [mailto:[hidden email]]
Sent: Friday, April 28, 2017 12:11 AM
To: [hidden email]
Subject: Source???

The above  advice is gold. If you assume  that  your  wife is the primary caregiver of  your  baby and get to the point of running 60, 80, 90 miles a week...you will not see  them very much and that will affect them deeply. My  dad worked 65 hours a  week when I was born and my sister was barely  1 year old -  out of necessity - and it was incredibly hard on my  mom, physically and emotionally.

That being  said, maybe  look into Timothy  Olsen's story or send him an email.  He is very kind  and he  and his wife might  be able  to offer advice. IIRC even he took  a step back when  their child  was born.


Sent from Mail for Windows 10
--
https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932
Your team OpenERP Community (OBSOLETE) is subscribed to branch lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher.
Loading...