[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Leonardo Pistone - Agile BG - Domsense
Leonardo Pistone - Agile BG - Domsense has proposed merging lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #933537 in OpenERP Addons: "v6 analytic: updating the module disables analytic accounting from all users except admin"
  https://bugs.launchpad.net/openobject-addons/+bug/933537

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

=== modified file 'analytic/security/analytic_security.xml'
--- analytic/security/analytic_security.xml 2011-06-08 11:21:09 +0000
+++ analytic/security/analytic_security.xml 2012-02-16 16:39:21 +0000
@@ -7,8 +7,5 @@
         <field eval="True" name="global"/>
         <field name="domain_force">['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]</field>
     </record>
-    <record id="group_analytic_accounting" model="res.groups" context="{'noadmin':True}">
-        <field name="name">Useability / Analytic Accounting</field>
-        <field name="users" eval="[(6,0,[ref('base.user_root')])]"/>
-    </record>
+
 </data></openerp>


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Stefan Rijnhart (Therp)
Review: Needs Fixing

Hi Leonardo,

thank you for this find. We were hit by this and we could not explain it.

With regards to your modification, I am afraid that it causes the group not to be created on new databases. Maybe you can replace the content of the eval attribute with

[(4,0,[ref('base.user_root')])]

so that it does not remove all the other users.

Cheers,
Stefan.

--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Stefan Rijnhart (Therp)
In reply to this post by Leonardo Pistone - Agile BG - Domsense
Sorry, that would be

[(4, ref('base.user_root'))]

--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Xavier ALT (OpenERP)
In reply to this post by Leonardo Pistone - Agile BG - Domsense
Hi Leonardo, Stefan,

This is definitely the way to do it, but make sure you use the right syntax for the link operation:

[(4, [ref('base.user_root')])]

So, no extra "0".

Cheers,
Xavier
--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Leonardo Pistone - Agile BG - Domsense
In reply to this post by Leonardo Pistone - Agile BG - Domsense
Stefan, Xavier,

You're definitely right, I mistakenly deleted the whole block.

The (4, ref) was my first thought, but I thought maybe that should be considered demo data? Is that the right place to assign groups to admin?

No big issue though, (4, ref) is alright, too

Thanks!
--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Naresh(OpenERP)
In reply to this post by Leonardo Pistone - Agile BG - Domsense
Hi Every One,

I would reject this merge proposal for the sake of clarity on the lp. As a new mp with the fixed discussed above has been proposed here https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-383700-skh/+merge/93563

Thanks,  
--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0

Naresh(OpenERP)
In reply to this post by Leonardo Pistone - Agile BG - Domsense
The proposal to merge lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone into lp:openobject-addons/6.0 has been updated.

    Status: Needs review => Rejected

For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
--
https://code.launchpad.net/~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone/+merge/93449
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/6.0-bug-933537-analytic-lpistone.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp