[Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Simone Orsi - Agile BG - Domsense
Simone Orsi - Agile BG - Domsense has proposed merging lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web.

Requested reviews:
  OpenERP R&D Web Team (openerp-dev-web)

For more details, see:
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649

'progress' value into gantt view was hardcoded as "100". Now the value is taken from the object. See also https://code.launchpad.net/~openerp-community/openobject-server/trunk-gantt-view-add-progress/
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

=== modified file 'addons/web_gantt/static/src/js/gantt.js'
--- addons/web_gantt/static/src/js/gantt.js 2012-01-16 10:28:47 +0000
+++ addons/web_gantt/static/src/js/gantt.js 2012-01-23 10:19:49 +0000
@@ -35,6 +35,7 @@
         this.date_start = this.fields_view.arch.attrs.date_start,
         this.date_delay = this.fields_view.arch.attrs.date_delay,
         this.date_stop = this.fields_view.arch.attrs.date_stop,
+        this.progress = this.fields_view.arch.attrs.progress,
         this.day_length = this.fields_view.arch.attrs.day_length || 8;
 
         this.color_field = this.fields_view.arch.attrs.color,
@@ -144,6 +145,7 @@
             var id = res['id'];
             var text = res[this.text];
             var start_date = res[this.date_start];
+            var progress = res[this.progress];
 
             if (this.date_stop != undefined){
                 if (res[this.date_stop] != false){
@@ -179,7 +181,7 @@
                             var mod_id = i+ "_" +j;
                             parents[grp_key] = mod_id;
                             child_event[mod_id] = {};
-                            all_events[mod_id] = {'parent': "", 'evt':[mod_id , grp_key, start_date, start_date, 100, ""]};
+                            all_events[mod_id] = {'parent': "", 'evt':[mod_id , grp_key, start_date, start_date, progress, ""]};
                         }
                         else{
                             mod_id = parents[grp_key];
@@ -191,7 +193,7 @@
                             child_event[mod_id][grp_key] = ch_mod_id;
                             child_event[ch_mod_id] = {};
                             temp_id = ch_mod_id;
-                            all_events[ch_mod_id] = {'parent': mod_id, 'evt':[ch_mod_id , grp_key, start_date, start_date, 100, ""]};
+                            all_events[ch_mod_id] = {'parent': mod_id, 'evt':[ch_mod_id , grp_key, start_date, start_date, progress, ""]};
                             mod_id = ch_mod_id;
                         }
                         else{
@@ -200,15 +202,15 @@
                         }
                     }
                 }
-                all_events[id] = {'parent': temp_id, 'evt':[id , text, start_date, duration, 100, ""]};
+                all_events[id] = {'parent': temp_id, 'evt':[id , text, start_date, duration, progress, ""]};
                 final_events.push(id);
             }
             else {
                 if (i == 0) {
                     var mod_id = "_" + i;
-                    all_events[mod_id] = {'parent': "", 'evt': [mod_id, this.name, start_date, start_date, 100, ""]};
+                    all_events[mod_id] = {'parent': "", 'evt': [mod_id, this.name, start_date, start_date, progress, ""]};
                 }
-                all_events[id] = {'parent': mod_id, 'evt':[id , text, start_date, duration, 100, ""]};
+                all_events[id] = {'parent': mod_id, 'evt':[id , text, start_date, duration, progress, ""]};
                 final_events.push(id);
             }
         }


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Xavier (Open ERP)
Review: Approve

While we're grateful for the work, the gantt view is being rewritten so it will end up not being used.

Still, I see no reason not to merge it before the rewrite is merged itself. Thanks for the work.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

noreply
In reply to this post by Simone Orsi - Agile BG - Domsense
The proposal to merge lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web has been updated.

    Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

eLBatti
In reply to this post by Simone Orsi - Agile BG - Domsense
Hello Xavier,
is it being rewritten for 6.1 ?

Btw, this functionality needs the following patch too
https://code.launchpad.net/~openerp-community/openobject-server/trunk-gantt-view-add-progress/+merge/89648

and project.task can use it this way
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Xavier (Open ERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
> is it being rewritten for 6.1 ?

Yes. The current version was found unusable (although we'll have to see if the new version is better).

> Btw, this functionality needs the following patch too

Ah, so this is actually a new feature? I'd misunderstood that, I probably shouldn't have merged it then.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Simone Orsi - Agile BG - Domsense
In reply to this post by Simone Orsi - Agile BG - Domsense
Actually is not a new feature, it's kind of a bug since the "progress" parameter was hardcoded into the web client as "100". In order to get rid of it you must allow the attribute to be validated into *.rng on the server side.

The other change into addons it's only a follow-up of this.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Xavier (Open ERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
> it's kind of a bug since the "progress" parameter was hardcoded into the web client as "100". In order to get rid of it you must allow the attribute to be validated into *.rng on the server side.

In other words, it *is* a new feature for OpenERP: the Gantt view as defined in OpenERP currently has no concept of progress for items, your proposals add one.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

eLBatti
In reply to this post by Simone Orsi - Agile BG - Domsense
It would certainly be better if standard components like gantt view didn't change completely during the "release candidate".
If it's supposed to happen, we should stop testing it.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Simone Orsi - Agile BG - Domsense
In reply to this post by Simone Orsi - Agile BG - Domsense
@lorenzo +1

and also, it would be nice to know what/when will going to replace it.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Nhomar Hernández
In reply to this post by Simone Orsi - Agile BG - Domsense
IMHO.

There are features that are a MUST TO HAVE, even in the middle of RC,

@Simone

Please be patience, we need good people helping improve and teste as you do here.....

@Xavier

Please, can you explain BETTER why replace a HARD CODED qty is a NEW feature?


Regards.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Xavier (Open ERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
> Please, can you explain BETTER why replace a HARD CODED qty is a NEW feature?

OpenERP's Gantt views don't have a notion of progress (hence no progress attribute in gantt views) at this point.

Adding a notion of progress to OpenERP's gantt view is a new feature (handling of progress).

I'm not sure what's controversial about it.

The value in openerp-web was only "hard-coded" because there was no provision for "soft-coding" it since there was no support for progress in gantt tasks. Hence the "value" was used on solely stylistic purposes, to display a filled bar (from my understanding, dhtmlxGantt requires some sort of value for progress, a value in ]0, 100[ would be misleading, the value 0 would be ugly — as it only displays borders. The value 100 was picked because it looks acceptably good.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

eLBatti
In reply to this post by Simone Orsi - Agile BG - Domsense
Xavier, displaying wrong information on graphs is not a bug? Is it correct to read "percentage complete: 100%" on the tasks' gantt view while they are not completed?

Moreover:

Simone Orsi - Agile BG - Domsense (simone-orsi) wrote 1 hour ago:

and also, it would be nice to know what/when will going to replace it.


--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

Xavier (Open ERP)
In reply to this post by Simone Orsi - Agile BG - Domsense
> Xavier, displaying wrong information on graphs is not a bug? Is it correct to read "percentage complete: 100%" on the tasks' gantt view while they are not completed?

Of course not, but that bug was fixable by looking into removing that section of the label, or removing the tooltip altogether. Or just by providing a value obviously nonsensical to the gantt chart library.

> Moreover:

I would have answered if I knew. I don't. Therefore I did not answer. I would recommend asking al about this.
--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress into lp:openerp-web

eLBatti
>
> Of course not, but that bug was fixable by looking into removing that section of the label, or removing the tooltip altogether. Or just by providing a value obviously nonsensical to the gantt chart library.

That is exactly what the patches do, they allow to provide a real
value (through the XML attribute 'progress') to the gantt chart:
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-gantt-view-add-progress/+merge/89653
https://code.launchpad.net/~openerp-community/openobject-server/trunk-gantt-view-add-progress/+merge/89648
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649

--
https://code.launchpad.net/~openerp-community/openerp-web/trunk-gantt-view-add-progress/+merge/89649
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-web/trunk-gantt-view-add-progress.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp