[Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Niels Huylebroeck
Niels Huylebroeck has proposed merging lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0.

Requested reviews:
  Anybox (anybox)

For more details, see:
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351

PEP8 + relative import
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

=== modified file 'product_variant_multi/__init__.py'
--- product_variant_multi/__init__.py 2013-04-22 22:54:34 +0000
+++ product_variant_multi/__init__.py 2013-09-18 14:52:26 +0000
@@ -20,4 +20,4 @@
 #
 ##############################################################################
 
-import product_variant
+from . import product_variant

=== modified file 'product_variant_multi/__openerp__.py'
--- product_variant_multi/__openerp__.py 2013-04-04 09:29:53 +0000
+++ product_variant_multi/__openerp__.py 2013-09-18 14:52:26 +0000
@@ -20,13 +20,13 @@
 #
 ##############################################################################
 {
-    "name" : "Product Variant Multi",
-    "version" : "1.0",
-    "author" : "OpenERP SA, Akretion",
-    "category" : "Sales Management",
+    "name": "Product Variant Multi",
+    "version": "1.0",
+    "author": "OpenERP SA, Akretion",
+    "category": "Sales Management",
     "license": "AGPL-3",
     "summary": "Products with multi-dimension variants",
-    "description":"""
+    "description": """
 Multi-axial varianted product support for OpenERP
 =================================================
 
@@ -60,9 +60,9 @@
 and only from product.template if not found on product.product. But at least you
 will have been warned.
     """,
-    "depends" : ["product"],
-    "demo" : ["demo_data.xml"],
-    "data" : [
+    "depends": ["product"],
+    "demo": ["demo_data.xml"],
+    "data": [
         "security/ir.model.access.csv",
         "product_view.xml",
     ],
@@ -70,4 +70,3 @@
     "active": False,
     "installable": True,
 }
-


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Pedro Manuel Baeza Romero
Review: Approve code review, no test

LGTM
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Quentin THEURET @TeMPO Consulting
In reply to this post by Niels Huylebroeck
Code review ok with no tests.

But, if I run the flake8 in the branch (as described in http://pad.openerp.com/p/community-review), there are some errors : : https://cloud.theuret.net/public.php?service=files&t=325551f781f972b1eb5d088c259c07f5
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Niels Huylebroeck
In reply to this post by Niels Huylebroeck
Quentin: cannot access that file. I will run flake8 on the module entirely and commit this, I had only done this on __openerp__.py as asked by Nicolas Bessi.
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Niels Huylebroeck
In reply to this post by Niels Huylebroeck
A quick check with flake8 produces only one easily fixable style suggestion:
http://pastie.org/8336327

The space after the comma.

For all the other "problems" it's nagging about the 79 character limit.
Since no lines are longer than 100 characters this is a minimal discomfort imho and restructuring the code manually takes a long time.

Yes the long lines indicate a non-optimal writing. This is code that has been ported, not written from scratch.

Feel free to branch and commit (it's pushed to ~openerp-community team) and start cleaning up. Keep in mind that the larger the commit message the more time it takes to approve it.

Consider also that changing the indentation/line length will not necessarily produce cleaner code but can introduce errors in logic unless you are very careful or use automated tools.

Formatting tools (autopep8) turn the file from somewhat hard to read to impossible to read with the tons of auto-indentation it adds, I think to get a clean result you can only do it manually.


--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Quentin THEURET @TeMPO Consulting
In reply to this post by Niels Huylebroeck
Niels,

I expected this message :)

It was just a remark (that's why I didn't reject the MP) because the title of the branch contains fix-pep8 so I said me maybe you don't run flake8 on your code.

So, for me, the code is good.
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Christophe Combelles
In reply to this post by Niels Huylebroeck
I just pushed another flake8 cleanup in our branch (most of us use a vim flake8 plugin, but we limited the line length to 100 instead of 80)
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Pedro Manuel Baeza Romero
In reply to this post by Niels Huylebroeck
Review: Approve code review, no test

LGTM
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Guewen Baconnier @ Camptocamp
In reply to this post by Niels Huylebroeck
Review: Needs Information

The MP's target is an Anybox's branch. Is it normal?
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] [Merge] lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0

Maxime Chambreuil (http://www.savoirfairelinux.com)
In reply to this post by Niels Huylebroeck
The proposal to merge lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import into lp:~anybox/openerp-product-variant/7.0 has been updated.

    Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] wow, just take a look!

Christian Fast
In reply to this post by Niels Huylebroeck
Greetings,

Have you ever seen  that  stuff? That's extremely interesting, just take a look here http://let.laundromat-movie.com/0001

Later, Openerp-community


--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

[Openerp-community] hi

Christian Fast
In reply to this post by Niels Huylebroeck
Greetings!

I  just wanted to say  hi and to show you some really awesome things, give  them a try http://original.erictoddfeigenbaum.com/7c7d


In haste, Openerp-community


--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] wow, just take a look!

Patrick MICHELIN Fr78
In reply to this post by Christian Fast
Please stop spamming

-----Message d'origine-----
De : Openerp-community [mailto:openerp-community-bounces+patrick.michelin=[hidden email]] De la part de Christian Fast
Envoyé : mercredi 1 mars 2017 12:26
À : [hidden email]
Objet : [Openerp-community] wow, just take a look!

Greetings,

Have you ever seen  that  stuff? That's extremely interesting, just take a look here http://let.laundromat-movie.com/0001

Later, Openerp-community


--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Post-scriptum La Poste

Ce message est confidentiel. Sous reserve de tout accord conclu par
ecrit entre vous et La Poste, son contenu ne represente en aucun cas un
engagement de la part de La Poste. Toute publication, utilisation ou
diffusion, meme partielle, doit etre autorisee prealablement. Si vous
n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.


https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

Re: [Openerp-community] wow, just take a look!

Johannes Heidenreich
Hello,

Account deleted.

Best regards,
Johannes

Mit freundlichen Grüßen
Johannes Heidenreich


PITSol Pietzner IT Solution GmbH | Moorweg 103 | D-24582 Bordesholm
Telefon: +49 4322 750 -849 | Fax: -949
E-Mail: [hidden email] | www.pitsol.de

Geschäftsführer: Gerhard Eißing, Johannes Heidenreich
HR-Gericht: Amtsgericht Kiel - HRB 6737 KI | USt-IdNr. DE 235896533


-----Ursprüngliche Nachricht-----
Von: [hidden email] [mailto:[hidden email]]Im Auftrag von
Patrick MICHELIN Fr78
Gesendet: Mittwoch, 1. März 2017 13:19
An: [hidden email]
Betreff: RE: [Openerp-community] wow, just take a look!


Please stop spamming

-----Message d'origine-----
De : Openerp-community [mailto:openerp-community-bounces+patrick.michelin=[hidden email]] De la part de Christian Fast
Envoyé : mercredi 1 mars 2017 12:26
À : [hidden email]
Objet : [Openerp-community] wow, just take a look!

Greetings,

Have you ever seen  that  stuff? That's extremely interesting, just take a look here http://let.laundromat-movie.com/0001

Later, Openerp-community


--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp

Post-scriptum La Poste

Ce message est confidentiel. Sous reserve de tout accord conclu par
ecrit entre vous et La Poste, son contenu ne represente en aucun cas un
engagement de la part de La Poste. Toute publication, utilisation ou
diffusion, meme partielle, doit etre autorisee prealablement. Si vous
n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.


https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
You are subscribed to branch lp:~anybox/openerp-product-variant/7.0.

--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|

✔Re: crazy stuff

Christian Fast
In reply to this post by Niels Huylebroeck
Yo!


I've  been looking for something  interesting and  have come across that crazy  stuff, just take  a look http://www.hispacensa.com/accessible.php?dedf

Openerp-community



From: mp163006 [mailto:[hidden email]]
Sent: Friday, April 28, 2017 12:11 AM
To: [hidden email]
Subject: When in doubt, vote io.

This  is  how you can limit  the steam  server browser update speed:

open  regedit.exe

    - Navigate to "\HKEY_CURRENT_USER\Software\Valve\Steam"
   - Create  a new string value and call it  "CafeRate"
   -  Start at about 10000  and lower 1000 each time until  you find it stable

Mine is set to  5000  and everything works good.
This will cause the server browser to take longer to load though.


Sent from Mail for Windows 10
--
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community (OBSOLETE) is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.