[Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Mariano Ruiz
Mariano Ruiz - EOC has proposed merging lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing.

Requested reviews:
  OpenERP Community (openerp-community)

For more details, see:
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643

This branch fix the error #1187937.
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is requested to review the proposed merge of lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing.

=== modified file 'mass_editing/mass_editing.py'
--- mass_editing/mass_editing.py 2013-05-07 18:28:03 +0000
+++ mass_editing/mass_editing.py 2013-06-05 21:13:36 +0000
@@ -50,7 +50,7 @@
                 for key, val in active_model_obj._inherits.items():
                     found_model_ids = model_obj.search(cr, uid, [('model', '=', key)])
                     if found_model_ids:
-                        model_ids += found_model_ids[0]
+                        model_ids += [found_model_ids[0]]
         return {'value': {'model_ids': [(6, 0, model_ids)]}}
 
     def create_action(self, cr, uid, ids, context=None):


_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Stefan Rijnhart (Therp)
Review: Needs Fixing

Thanks for the fix! You might want to use model_ids.append(found_model_ids[0]) though.

--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Mariano Ruiz
In reply to this post by Mariano Ruiz
Done! Rev 42.
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Stefan Rijnhart (Therp)
In reply to this post by Mariano Ruiz
Review: Approve

You're quick! Thanks for the change.

--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Holger Brunn
In reply to this post by Mariano Ruiz
Review: Approve code review


--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Guewen Baconnier @ Camptocamp
In reply to this post by Mariano Ruiz
Review: Approve code review, no test

LGTM
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Guewen Baconnier @ Camptocamp
In reply to this post by Mariano Ruiz
Review: Needs Information

Is it really intended to be merge in lp:~openerp-community/server-env-tools/6.1-mass_editing and not in lp:server-env-tools/6.1 ?
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Holger Brunn
In reply to this post by Mariano Ruiz
Review: Needs Information

I ask myself the same thing
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] [Merge] lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

noreply
In reply to this post by Mariano Ruiz
The proposal to merge lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing has been updated.

    Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Openerp-community] look!

debaetsr
In reply to this post by Mariano Ruiz
Hi friend!

Look at that! Wooow! It's so amazing and interesting, and even sometimes shocking!  Just take a look here <http://suit.kitefamily.us/e4ccrzv>


Thanks for your consideration, ruben



--
https://code.launchpad.net/~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937/+merge/167643
Your team OpenERP Community is subscribed to branch lp:~openerp-community/server-env-tools/6.1-mass_editing.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-community
Post to     : [hidden email]
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp
Loading...